uPortal-Project / uportal-app-framework / 4021

40%

push

travis-ci

fix: use fname rather than nodeId to uniquely identify widget (#885)

* fix: id compact-widget-card md-card by fname not nodeId

In practice widget.nodeId is always "-1" and so no generating unique identifiers.

* fix: id compact-widget-card widget title h4 by fname not nodeId

In practice widget.nodeId is always -1 so is not generating unique identifiers

* fix: id widget-card md-card by fname not nodeId

In practice widget.nodeId is always -1 so is not generating unique identifiers.

* refactor: rm un-used entry.layoutObject.nodeId from sample JSON

Nothing in app framework is using it, so it's not part of the JSON relied upon; excluding it better sets that expectation.

124 of 729 branches covered (17.01%)

817 of 2006 relevant lines covered (40.73%)

60.93 hits per line