helpscout / hsds-react / 1803

94%

push

travis-ci

Dropdown: Fix ComboBox positioning with shouldDropDirectionUpdate (#515)

* Dropdown: Fix ComboBox positioning with shouldDropDirectionUpdate

This update fixes the up/down menu position of `ComboBox` based dropdowns
that happens when the list size changes (during filtering).

The solution was to introduce a new prop called `shouldDropDirectionUpdate`.
By default, in `Dropdown`, it resolves to `true`. However, in `ComboBox`,
we'll resolve it to `false`.

The user can adjust this, if required.

* Handle case for ComboBox + dropUp

* Fix MenuContainer test

* Adjust blue in VSCode to new Blue 500

3483 of 3483 branches covered (100.0%)

Branch coverage included in aggregate %.

6969 of 6969 relevant lines covered (100.0%)

259.18 hits per line