harfbuzz / harfbuzz / 6576

79%

push

travis-ci

<a href="https://github.com/harfbuzz/harfbuzz/commit/<a class=hub.com/harfbuzz/harfbuzz/commit/d936ad4582a0017cf88406372d7c08b9896beed6">d936ad458<a href="https://github.com/harfbuzz/harfbuzz/commit/d936ad4582a0017cf88406372d7c08b9896beed6">&quot;&gt;Fix hb_atomic_* variants based on C++11 atomics

I stumbled over this when trying to upgrade the version of HarfBuzz used by
LibreOffice to 3.2.1 (see &amp;lt;https://gerrit.libreoffice.org/plugins/gitiles/core/
+/</a><a class="double-link" href="https://github.com/harfbuzz/harfbuzz/commit/<a class="double-link" href="https://github.com/harfbuzz/harfbuzz/commit/b7ddc514bff9bdf682abae537f990aa01dc2c0fb">b7ddc514b</a>">b7ddc514b</a><a href="https://github.com/harfbuzz/harfbuzz/commit/d936ad4582a0017cf88406372d7c08b9896beed6">%5E!/&gt; &quot;Upgrade to latest
HarfBuzz 2.3.1&quot;), where building with MSVC 2017 failed like

&gt; c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2440: &#39;reinterpret_cast&#39;: cannot convert from &#39;const int *&#39; to &#39;std::atomic&lt;int&gt; *&#39;
&gt; c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): note: Conversion loses qualifiers
&gt; c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2227: left of &#39;-&gt;load&#39; must point to class/struct/union/generic type

(see &lt;https://ci.libreoffice.org/job/gerrit_windows/29916/&gt;).

I added all the necessary &quot;const&quot; to make building of HarfBuzz 2.3.1 with
MSVC 2017 succeed for me.  There may be more missing at least conceptually.

9565 of 12694 relevant lines covered (75.35%)

6607.52 hits per line