379
72%

Ran 05 Mar 2019 03:40PM UTC

Jobs 1

Files 494

Run time 3min

Badge

Embed ▾

pending completion

Build # 379

Build Type

push

jenkins

Committed by GitHub

Commit Message

[DLOG] Avoid double read in readahead

There was a bug in the ReadAheadReader whereby, if it was in a paused
state and the last segment it had read had been closed, then when a
writer started writing new segments, the ReadAheadReader would issue a
double read. This would end up triggering an error when it got to the
end of the segment as the issued one of the issued reads would then be
cancelled when the segment was closed.

This fix adds an explicit state machine to the reader and moves all
state transitions to run on the ordered executor, so only one read can
ever be issued at a time.


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #1973 from ivankelly/dlog-reader-crash-master

Run Details

26497 of 36596 relevant lines covered (72.4%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	379.1	05 Mar 2019 03:40PM UTC	0	72.4

Source Files on build 379

Detailed source file information is not available for this build.

apache / bookkeeper / 379
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 379

apache / bookkeeper / 379 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 379

apache / bookkeeper / 379
72%

README BADGES
x