aiidateam / aiida_core / 5430

70%

develop: 74%

push

travis-ci

Importing `metadata` for `Log`-entries properly. (#2486)

The test tries to test the case in issue #2448,
where a specific Node has a few Log messages.
Then one wants to import a file that has more Log messages,
pertaining to the exact same Node.
The test checks that all Log messages are imported according
to their UUID.

Added ex-/import test: `test_reimport_of_logs_for_single_node`
Added simple test: `test_export_of_imported_logs`.

The test checks if one can re-export imported Logs.

Correct import of Logs into sqla from django.

Check a Log's metadata is JSON serializable upon construction.

Add test of Logs to check correct metadata format.

Add type check of metadata when constructing new Log.

Make sure uuid is a string when retrieving it for comparisons,
during import with SQLA.
This was already the case for import with django.
This is crucial, since Log.uuid returns a UUID() type.
To make a proper comparison and ensure we do not try to insert an existing Log,
this MUST be converted to a string, i.e. str(UUID())

Tests for importing existing comments.

Added `comment_mode` to import, which may be:
 - `'newest'`: Will keep the Comment with most recent mtime.
 - `'overwrite'`: Will overwrite existing Comments with the ones from the import file.

Added `delete_many` method to comments.
Acts within a session for SQLA.

Minor fixes to import of extras.

Changed default `extras_mode_new` from `'ignore'` to `'import'` in `import_data_sqla`.
This is to make it the same as for `import_data_dj`.
Furthermore, `'ignore'` was not a valid value.

Update docstrings of import_data* functions

Check `mtime` is the same before and after export/import.
Both for Node and Comment.

Centralized import check of Comments in `_merge_comment` function.
It will update existing Comments if needed, NOT delete entries.

Updated `delete_many` method to accept filters.
Both for Logs and Comments and both for django and SQLA.... (continued)

163 of 163 new or added lines in 13 files covered. (100.0%)

24061 of 34182 relevant lines covered (70.39%)

2.57 hits per line