2254
92%

Ran 04 Mar 2019 10:18PM UTC

Jobs 1

Files 40

Run time 12s

Badge

Embed ▾

pending completion

Build # 2254

Build Type

push

travis-ci

Committed by

olleolleolle

Commit Message

Fix test order dependency in default_connection proxy test (#929)

* Fix the default_connection proxy test

The assignment to the mock connection:

`Faraday.default_connection = mock_connection`

was persisting throughout the tests.

If the random number generator is unlucky the following error occurs:

\#<Double "Connection"> was originally created in one example but has leaked into another example and can no longer be used.  rspec-mocks' doubles are designed to only last for one example, and you need to create a new one in each example you wish to use it for.

This commit fixes the issue by explicitly setting the default_connection
back to nil in an "after" block after the tests have run.

Subsequent calls to `default_connection` within the test suite then
behave as previously expected irrespective of the random test ordering.

Run Details

1633 of 1747 relevant lines covered (93.47%)

889.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
5	2254.5 (ruby-head)	04 Mar 2019 10:18PM UTC	0	93.47	Travis Job 2254.5

Source Files on build 2254

Detailed source file information is not available for this build.

lostisland / faraday / 2254
92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2254

lostisland / faraday / 2254 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2254

lostisland / faraday / 2254
92%

README BADGES
x