ebi-gene-expression-group / scxa-faceted-search-results / 242

94%

push

travis-ci

<a href="https://github.com/ebi-gene-expression-group/scxa-faceted-search-results/commit/<a class=hub.com/ebi-gene-expression-group/scxa-faceted-search-results/commit/ea29e4930c1e545d01e18aeb62b9c350f16eae09">ea29e4930<a href="https://github.com/ebi-gene-expression-group/scxa-faceted-search-results/commit/ea29e4930c1e545d01e18aeb62b9c350f16eae09">&quot;&gt;Feature #162304903 remove facets shared by all results (#14)

* Test real data

* Reformat FilterSidebar by pass cleaned facetGroups

* Clean up code style

* Clean checkbox facetGroups and clean up codes

* Reformat the FilterSidebar with tidy facet groups

* Reformat container and pass results to sidebar

* Clean up code style

* Add required props in test

* Remove unused commands

* Update snapshots

* Update testutils with markerGenes and species

* Add a test for hiding a facet shared by all result

* Clean up code

* Add a filter method remove facets shared by all

* Clean up codes, delete old methods

* Remove unused props

* Revert &amp;quot;Remove unused props&quot;

This reverts commit </a><a class="double-link" href="https://github.com/ebi-gene-expression-group/scxa-faceted-search-results/commit/<a class="double-link" href="https://github.com/ebi-gene-expression-group/scxa-faceted-search-results/commit/f4f3042895711117220e3e164a9cf93685757597">f4f304289</a>">f4f304289</a><a href="https://github.com/ebi-gene-expression-group/scxa-faceted-search-results/commit/ea29e4930c1e545d01e18aeb62b9c350f16eae09">.

* Disable facets after intial search results

* Remove useless props and define propTypes

* Assign clearedFacets in constructor and clean code

* Reorganise demo pages and update experiments results/header components

* Fix linter warnings/errors

* Trim and update dependencies

* Fix typo on CheckboxOption.propTypes

* Fix test environment for fetch

* Remove facet markerGenes in TestUtils; move common facet to test data

* Remove closure for facet-trimming, we’re only running this once

* Add comment to see trimming of shared facets in action

58 of 65 branches covered (89.23%)

Branch coverage included in aggregate %.

22 of 22 new or added lines in 5 files covered. (100.0%)

118 of 121 relevant lines covered (97.52%)

35.6 hits per line