CyberShadow / aconfmgr / 128

94%

push

travis-ci

Fix adding, then removing a directory

If a directory containing files was present in the configuration but
not the system, aconfmgr would emit RemoveFile commands for the
directory, and then its containing files. This would fail due to
`rm` (issued by RemoveFile) failing to remove a directory.

Fix this by:

1. Reversing the order that configuration-only files are iterated over
   when emitting RemoveFile commands. This should ensure that child
   filesystem objects are removed before their containing directories.

2. Invoking `rm` with `--dir` from RemoveFile, thus allowing the
   removal of emptied directories. (Use `--dir` instead of
   `--recursive`, as the latter should be excessive.)

Fixes #38.

12 of 12 new or added lines in 3 files covered. (100.0%)

1921 of 2387 relevant lines covered (80.48%)

315.49 hits per line