zeroclipboard / zeroclipboard / 424

62%

Pull #561

travis-ci

Prevent "TypeError styles = null" error in Firefox

I'm getting errors in the latest Firefox only where "styles is null".  It's referring to line 1629 on the latest ZeroClipboard (https://github.com/zeroclipboard/zeroclipboard/blob/master/dist/ZeroClipboard.js): `var hasCssHeight = _parseFloat(styles.height) > 0;`

In my tests between Chrome (where there is no error) and Firefox, it seems like Firefox is calling _isElementVisible() on load.  It passes an object in but it's not a HTML element, and so `_getComputedStyle` isn't returning anything.  Adding this little extra check fixed the issue for me in my local build.

2 of 2 new or added lines in 1 file covered. (100.0%)

1962 of 3160 relevant lines covered (62.09%)

29.7 hits per line