xapi-project / sm / 732

47%

push

travis-ci

CA-298641: be more benign on removing host tag

There are two reasons for this change:

  - For some cases, there can be no host tags present. E.g. on directly attached
    HA statfile, or some accidental failure when adding the tags.

  - remove_tags is called at the end of VDI detach, which is to cease, rather
    than to start, destructive operations. Even if the host tag is not present
    for some reason, simply ignoring this and going ahead won't make the
    situation worse. If there was damange, it was done already (at the time of
    attching and onwards). Simply aborting at this point will probably make
    things messier.

Signed-off-by: Zheng Li <zheng.li3@citrix.com>

828 of 6394 branches covered (12.95%)

7002 of 20909 relevant lines covered (33.49%)

0.33 hits per line