cloudmarker / cloudmarker / 305

84%

push

travis-ci-com

Upgrade setuptools for Travis CI Python 3.4 builds

A build failure occurs in Travis CI builds for Python 3.4 since the
release of `isort 4.3.9`. The build failure occurs due to the following
combination of different factors:

 1. The latest version of `isort` at this time is `isort 4.3.9` which
    was released very recently on Feb 26, 2019.

 2. The `isort 4.3.9` package brings back (perhaps inadvertently) a
    conditional dependency on the `futures` package:

        futures; python_version < "3.2"

 3. When our project's dependencies are installed, `isort 4.3.9` gets
    installed but the `futures` package is ignored because the
    conditional dependency is not satisfied for Python versons 3.4 and
    above. This is correct behaviour.

 4. But during installation, the old version of `setuptools`, i.e.,
    `setuptools 35.0.2`, does not record the conditional dependency in
    the installed `METADATA` file of `isort`. The dependency is recorded
    as an unconditional dependency:

        Requires-Dist: futures

    This is incorrect behaviour. If the dependency were correctly
    recorded as a conditional dependency in the `METADATA` file, it would
    have looked like this:

        Requires-Dist: futures; python_version < "3.2"

    This dependency is correctly recorded in the `METADATA` file by
    `setuptools 36.2.0` and later versions.

 5. Pylama loads `isort` via `pkg_resources`. See `entry.load()()` call
    in `pylama/lint/extensions.py` for this call. This is a call into
    the `pkg_resources` package (part of `setuptools`).

 6. The `pkg_resources` code checks for dependencies in the installed
    `METADATA` file of `isort`, finds that `futures` is an unconditional
    dependency due to point 4 above, fails to find `futures` due to
    point 3 above, and fails with `pkg_resources.DistributionNotFound`
    error.

The issue is resolved by upgrading `setuptools` to the latest version in
Travis CI build environment for Python 3.4. The l... (continued)

78 of 111 branches covered (70.27%)

Branch coverage included in aggregate %.

467 of 590 relevant lines covered (79.15%)

2.37 hits per line