RolifyCommunity / rolify / 687

93%

push

travis-ci

<a href="https://github.com/RolifyCommunity/rolify/commit/<a class=hub.com/RolifyCommunity/rolify/commit/199ca1e602da831cc06e37d36e820ba26ac65970">199ca1e60<a href="https://github.com/RolifyCommunity/rolify/commit/199ca1e602da831cc06e37d36e820ba26ac65970">&quot;&gt;Significantly optimize #without_role (#500)

* :scissors: remove some obsolete code

since https://github.com/RolifyCommunity/rolify/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/RolifyCommunity/rolify/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/RolifyCommunity/rolify/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git">&lt;a class=</a>hub.com/RolifyCommunity/rolify/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/RolifyCommunity/rolify/commit/<a class=hub.com/RolifyCommunity/rolify/commit/<a class="double-link" href="https://git"><a class=hub.com/RolifyCommunity/rolify/commit/522c0d7d84a70dd3576b569edf19f9f6cb118a61">522c0d7d8">522c0d7d8</a><a href="https://github.com/RolifyCommunity/rolify/commit/199ca1e602da831cc06e37d36e820ba26ac65970"> Rails &lt; 4 is no longer supported

* significantly optimize #without_role

Imagine a big production application with millions of users.

The previous version generates 3 queries for `User.without_role(:admin)`:
1) For `user.all` in [`#all_except`](https://github.com/RolifyCommunity/rolify/blob/522c0d7d84a70dd3576b569edf19f9f6cb118a61/lib/rolify/adapters/active_record/role_adapter.rb#L83):
```sql
SELECT &quot;users&quot;.* FROM &quot;users&quot;
```
2) For `self.with_role(role_name, resource)` in [`#without_role`](https://github.com/RolifyCommunity/rolify/blob/522c0d7d84a70dd3576b569edf19f9f6cb118a61/lib/rolify/finders.rb#L8):
```sql
SELECT &quot;users&quot;.* FROM &quot;users&quot; INNER JOIN &quot;users_roles&quot; ON &quot;users_roles&quot;.&quot;user_id&quot; = &quot;users&quot;.&quot;id&quot; INNER JOIN &quot;roles&quot; ON &quot;roles&quot;.&quot;id&quot; = &quot;users_roles&quot;.&quot;role_id&quot; WHERE (((roles.name = &#39;admin&#39;) AND (roles.resource_type IS NULL) AND (roles.resource_id IS NULL)))
```
3) For `user.where(prime_key =&gt; (user.all - excluded_obj).map(&amp;prime_key))` in [`#all_except`](https://github... (continued)

3 of 3 new or added lines in 2 files covered. (100.0%)

1607 of 1737 relevant lines covered (92.52%)

400.84 hits per line