702
71%
master: 77%

Ran 27 Feb 2019 09:10AM UTC

Jobs 1

Files 36

Run time 7s

Badge

Embed ▾

pending completion

Build # 702

Build Type

push

travis-ci

Committed by

ivmai

Commit Message

Avoid potential race in hb_sz access between realloc and reclaim_block

Issue #240 (bdwgc).

GC_realloc might be changing the block size while GC_reclaim_block
is examining it.  The change to the size field is benign, i.e.
GC_reclaim would work correctly with either value, since we are not
changing the number of objects in the block.  But seeing a half-updated
value (though unlikely to occur in practice) could be probably bad.
Using unordered atomic fetch of hb_sz field should solve the issue.

* reclaim.c (GC_block_nearly_full, GC_reclaim_small_nonempty_block):
Add sz argument; use sz instead of hhdr->hb_sz.
* reclaim.c (GC_reclaim_clear, GC_reclaim_uninit, GC_reclaim_check):
Skip the assertion about hhdr->hb_sz if THREADS.
* reclaim.c [ENABLE_DISCLAIM] (GC_disclaim_and_reclaim): Likewise.
* reclaim.c [AO_HAVE_load] (GC_reclaim_block): Use AO_load to access
hhdr->hb_sz; add comments.
* reclaim.c (GC_reclaim_block): Pass sz to
GC_reclaim_small_nonempty_block() and GC_block_nearly_full().
* reclaim.c (GC_continue_reclaim, GC_reclaim_all): Pass hhdr->hb_sz to
GC_reclaim_small_nonempty_block().
* reclaim.c [!EAGER_SWEEP && ENABLE_DISCLAIM]
(GC_reclaim_unconditionally_marked): Likewise.

Run Details

5331 of 7713 relevant lines covered (69.12%)

1944987.57 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
34	702.34 (CONF_OPTIONS="--enable-gcov --enable-single-obj-compilation --enable-cplusplus --disable-shared --enable-gc-assertions" CFLAGS_EXTRA="-D USE_CUSTOM_SPECIFIC" REPORT_COVERAGE=true)	27 Feb 2019 09:10AM UTC	0	69.12	Travis Job 702.34

Source Files on build 702

Detailed source file information is not available for this build.

ivmai / bdwgc / 702
71%
master: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 702

ivmai / bdwgc / 702 71% master: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 702

ivmai / bdwgc / 702
71%
master: 77%

README BADGES
x