2490
96%

Ran 26 Feb 2019 11:18PM UTC

Jobs 1

Files 41

Run time 6s

Badge

Embed ▾

pending completion

Build # 2490

Build Type

push

travis-ci

Committed by

Rackover

Commit Message

Issue/#300 fix ladder win ratio (#396)

* Remove overridden on_game_end

This code used to call a private function which updated the league tables. However, this code was removed 'temporarily' in late 2015 with promises of being replaced by 'the new system', leaving on_game_end to do nothing.

* Add more tests for ladder game

* Refactored from_strings and added function for determining game outcome

* Update test to make sure winGames is being incremented

* Increment winGames for ladder matches

* Use await syntax

* Refactor

* Fix typo in docstring, improve typing

* Use async syntax, add more typing

* Check numGames and winGames more thoroughly. Fix winGames bug

* Ladder game use GameOutcome

* Adjusted get_army_score to prefer the most frequently reported score

* Make ladder games only report 0 or 1 for the score

* Remove unused function is_draw

* Added script for updating aggregate win rates

* Updates will be done through a db migration. See FAForever/db#188

* Code review changes

* Travis use python 3.6

* Some small typing/import cleanups

* Refactor _player_options with defaultdict

* Refactor get_player_option to account for default dict

* Fix tests after merge

* Update game connection command handlers

* Added handler for Disconnected and *args for unknown functions

Run Details

2547 of 3091 relevant lines covered (82.4%)

0.82 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2490.1	26 Feb 2019 11:18PM UTC	0	82.4	Travis Job 2490.1

Source Files on build 2490

Detailed source file information is not available for this build.

FAForever / server / 2490
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2490

FAForever / server / 2490 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2490

FAForever / server / 2490
96%

README BADGES
x