patternfly / patternfly-react / 4733

78%

Build Type

push

travis-ci

Committed by Donald Labaj

Commit Message

Single select (#1277)

* feat(Select): add single select variant

add tests, ts declarations. build select wrapper for future variant types

* refactor(Select): update TS declarations

also locally test TS

* feat(Select): update TS, clean up ref and openedOnEnter syntax

* fix(Select): fix onKeyDown syntax

* fix(Select): add missing toggle text class, update example

* feat(Select): add alternate placeholder option

* feat(Select): incorporate pr feedback

* fix(Select): update styles imports

* feat(Select): add width control to select container

defaults to 100%

* feat(Select): update with accessibility feedback, fix selected option logic

* feat(Select): add aria-labelledby & label id prop

* fix(Select): fix for toggle width, fix for disabling keyboard input when not focused in options

If toggle has focus and menu is open, keyboard input should behave as normal except for space and
enter

* fix(Select): remove unused Select prop, fix missing case for clearing keyboard focus, add missing to

* feat(Select): use helpers, use key types from constants

* feat(Select): update with PR feedback

rename aria labelled by, use constants, add missing props, update TS

* feat(Select): remove alternate declarations, update tests for console warnings

* fix(Select): remove toggle ts

* fix(Select): fix eslint errors

* feat(Select): add Select to TS demo, export SelectVariant for TS

Run Details

1998 of 2970 branches covered (67.27%)

Branch coverage included in aggregate %.

89 of 89 new or added lines in 5 files covered. (100.0%)

4673 of 5545 relevant lines covered (84.27%)

23.52 hits per line