skeema / tengo / 113

92%

main: 94%

push

travis-ci

Routines: Query mysql.proc if available for faster introspection

In flavors where mysql.proc still exists (currently everything but MySQL 8.0
and Percona Server 8.0), introspection of routines now queries mysql.proc
once in bulk, instead of running concurrent SHOW CREATE queries. This is
potentially a major speed-up for pre-8.0 users who have a very large number
of routines.

This commit also fixes potential character conversion problems with the Body
field of the Routines struct. Previously it was always populated from
information_schema.routines.body, but that is not consistently suitable for
returning SQL that can be re-executed. Instead, the Body is now obtained from
either mysql.proc or by parsing SHOW CREATE output.

For more information on the problem with information_schema.routines.body, see
this excellent blog post by Peter Gulutzan:
https://ocelot.ca/blog/blog/2017/08/22/no-more-mysql-proc-in-mysql-8-0/

37 of 37 new or added lines in 2 files covered. (100.0%)

2388 of 2602 relevant lines covered (91.78%)

153.93 hits per line