9965
73%
master: 37%

Ran 17 Feb 2019 03:29AM UTC

Jobs 1

Files 83

Run time 4739min

Badge

Embed ▾

pending completion

Build # 9965

Build Type

Pull #3575

travis-ci

Committed by

web-flow

Commit Message

easy: fix win32 init to work without CURL_GLOBAL_WIN32

- Change the behavior of win32_init so that the required initialization
  procedures are not affected by CURL_GLOBAL_WIN32 flag.

libcurl via curl_global_init supports initializing for win32 with an
optional flag CURL_GLOBAL_WIN32, which if omitted was meant to stop
Winsock initialization. It did so internally by skipping win32_init()
when that flag was set. Since then win32_init() has been expanded to
include required initialization routines that are separate from
Winsock and therefore must be called in all cases. This commit fixes
it so that CURL_GLOBAL_WIN32 only controls the optional win32
initialization (which is Winsock initialization, according to our doc).

The only users affected by this change are those that don't pass
CURL_GLOBAL_WIN32 to curl_global_init. For them this commit removes the
risk of a potential crash.

Ref: https://github.com/curl/curl/pull/3573

Fixes https://github.com/curl/curl/issues/3313
Closes #xxxx

Pull Request Pull Request #3575: easy: fix win32 init to work without CURL_GLOBAL_WIN32

Run Details

3637 of 4974 relevant lines covered (73.12%)

0.0 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	92.97	-0.14%	lib/urlapi.c
1	84.67	-0.13%	lib/easy.c
1	82.05	-0.05%	lib/ftp.c
2	72.19	-0.42%	lib/smb.c
5	52.08	-0.48%	lib/http2.c

Jobs

ID	Job ID	Ran	Files	Coverage
24	9965.24 (T=coverage)	17 Feb 2019 01:39PM UTC	273	75.97	Travis Job 9965.24

curl / curl / 9965
73%
master: 37%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 9965

curl / curl / 9965 73% master: 37%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 9965

curl / curl / 9965
73%
master: 37%

README BADGES
x