10154
66%

Ran 12 Feb 2019 10:17PM UTC

Jobs 2

Files 89

Run time 79min

Badge

Embed ▾

Committed 12 Feb 2019 09:59PM UTC coverage: 63.568% (+0.01%) from 63.554%

Build # 10154

Build Type

push

travis-ci

Committed by

rolandshoemaker

Commit Message

VA: Promote singleDialTimeout, add preresolvedDialer timeout test. (#4049)

The `singleDialTimeout` field was previously a global `const` in the
`va` package. Making it a field of the VA impl (and the dialer structs)
makes it easier to test that it is working as expected with a smaller
than normal value.

A new `TestPreresolvedDialerTimeout` unit test is added that tests the
fix from https://github.com/letsencrypt/boulder/pull/4046

Without the fix applied:
```
=== RUN   TestPreresolvedDialerTimeout
--- FAIL: TestPreresolvedDialerTimeout (0.49s)
    http_test.go:86: fetch didn't timeout after 50ms
    FAIL
    FAIL  github.com/letsencrypt/boulder/va 0.512s
```

With the fix applied:
```
=== RUN   TestPreresolvedDialerTimeout
--- PASS: TestPreresolvedDialerTimeout (0.05s)
PASS
ok    github.com/letsencrypt/boulder/va 1.075s
```

Run Details

11031 of 17353 relevant lines covered (63.57%)

1.41 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
11	10154.11 (RUN="coverage" CONTAINER="netaccess")	12 Feb 2019 10:17PM UTC	0	63.57	Travis Job 10154.11
12	10154.12 (RUN="coverage" CONTAINER="netaccess")	12 Feb 2019 10:18PM UTC	0	63.57	Travis Job 10154.12

Source Files on build 10154

Detailed source file information is not available for this build.

letsencrypt / boulder / 10154
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10154

letsencrypt / boulder / 10154 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 10154

letsencrypt / boulder / 10154
66%

README BADGES
x