IAMconsortium / pyam / 661

100%

push

travis-ci

Extend the `utils.find_depth()` function to return depth (#192)

* add test to find depth

* extend `find_depth()` for returning depth (alternative to assert level)

* add to release notes

* rename internal function

* one more refactoring of internal `_find_depth()`

* move regexp-escaping to own function

* rework unit test for `find_depth()` to illustrate `startswith`behaviour

* change behaviour of `find_depth()` to only exclude `s` if  at start of a variable

* add a test for two `*` in `pattern_match()`

* add explicit test for behaviour of only counting depth after `s`

* only remove last wildcard in `find_depth()`

* use `find_depth()` directly in `_apply_filters()`

* rework docstring

* simplify internal functions and return `None` for `s not in variable`

as requested by @gidden

* refactor existing tests in `test_utils.py`

* migrate tests related to `find_depth()` to `test_utils.py`

as requested by @gidden

* explicitly only match variables starting with `s`

* return `False` for `find_depth()` with `level` if `s` is not in variable

* rewrite docstrings for `find_depth()`

as requested by @gidden

* extend tests for `find_depth()` corner case

* move check for `None` into `test` functions for Python 3.7 test failures

* exclude pep8 on named lambdas (E731) for stickler

* even more concise implementation of `find_depth` internals

as suggested by @gidden

* one last little clean-up to get it to a one-liner

17 of 17 new or added lines in 2 files covered. (100.0%)

1614 of 1916 relevant lines covered (84.24%)

3.36 hits per line