2092
99%
master: 99%

Ran 12 Feb 2019 09:39AM UTC

Jobs 2

Files 423

Run time 1min

Badge

Embed ▾

pending completion

Build # 2092

Build Type

push

travis-ci

Committed by

Commit Message

Ensure entries can be filtered by publication date

Trying to filter entries by publication date in the entry admin index
list caused an error of the form:

    Column 'published_at' in on clause is ambiguous

The combination of the `includes(:published_revision)` in
`scoped_collection` and the `:published_revision_published_at` filter
caused the revisions table to be joined twice, making the unqualified
column `published_at` in the query of the `Revision.published` scope
ambiguous.

Since there is no documented way to obtain the current table alias,
the `published` query has been rewritten to use hash syntax instead of
an SQL fragment.

The comparison of `published_until` can be replaced with a date
range. Since `published_at` is only ever set to the current time, its
value can never be in the future. Checking for its presence is
therefore equivalent to checking whether it lies in the past.

Duplicating the `published_at IS NOT NULL` check, to make precendence
of `AND` and `OR` operators explicit.

REDMINE-16490

Run Details

15617 of 15728 relevant lines covered (99.29%)

54.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2092.1 (2.3.1, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true)	12 Feb 2019 09:39AM UTC	0	99.27	Travis Job 2092.1
2	2092.2 (2.5.3, PUBLISH_THEME_DOC=true COVERALLS_PARALLEL=true)	12 Feb 2019 09:39AM UTC	0	99.28	Travis Job 2092.2

Source Files on build 2092

Detailed source file information is not available for this build.

tf / pageflow / 2092
99%
master: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2092

tf / pageflow / 2092 99% master: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2092

tf / pageflow / 2092
99%
master: 99%

README BADGES
x