TryGhost / Ghost-Admin / 4591

70%

push

travis-ci

🐛 Fixed Code Injection input fields not being clickable

no issue
- lazy loaded scripts such as the CodeMirror asset used on the Code Injection screen could throw errors such as `TypeError: Cannot set property 'modeOption' of undefined`
- this was caused by "loading" promise returned from the `lazyLoader` service returning as soon as the network request finished which can be before the loaded script has been parsed and run meaning any processing occurring after the promise returns could be depending on unloaded code
- switched the lazyLoader service's loading mechanism from an ajax fetch to insertion of a `<script>` tag which can have `load` event attached which _will_ return after parsing/loading has completed

1851 of 2961 branches covered (62.51%)

4302 of 6009 relevant lines covered (71.59%)

46.46 hits per line