vpulim / node-soap / 1613

95%

push

travis-ci

server: add option enableChunkedEncoding (#1043)

Using res.end() to write result instead of res.write() followed by
res.end() will cause node not to use chunked encoding and include
Content-Length header. (See nodejs/node#26005) This small distinction is
important with some client. For example, Windows 10's MDM enrollment
system will not accept chunked response
(https://docs.microsoft.com/en-us/windows/client-management/mdm/on-premise-authentication-device-enrollment).

This might improve compatibility with some other clients, too. However,
there's a small chance that some client may expect the response to be
chunked. So, I put this behind an option which defaults to enabled and
can be disabled if needed.

1234 of 1411 branches covered (87.46%)

11 of 11 new or added lines in 1 file covered. (100.0%)

2005 of 2149 relevant lines covered (93.3%)

14577.87 hits per line