999
61%

Ran 11 Feb 2019 12:01PM UTC

Jobs 1

Files 37

Run time 4s

Badge

Embed ▾

pending completion

Build # 999

Build Type

push

travis-ci-com

Committed by

jjcnn

Commit Message

Check contracts for payment acceptances (#409)

* Check contracts for payment acceptances

If a contract has no transitions which accept payment, raise a warning.

Also if a transition has any code path with potentially multiple
"accept" statements in it, raise a warning.  We do not raise an error
since it is not possible via static analysis to know for sure in all
cases whether multiple "accept" statements would be reached if
present, since this can be dependent on conditions which are only
known at run-time.  As a silly example, this transition may or may not
attempt to accept twice:

    transition donate_once_or_twice(twice : Bool)
      accept;
      match twice with
      | True => accept
      | False =>
        e = { _eventname : "Thanks" };
        event e
      end
    end

In contrast, this transition is guaranteed to accept only once:

    transition donate_once(switch : Bool)
      match switch with
      | True => accept
      | False =>
        e = { _eventname : "Thanks" };
        event e
      end;
      match switch with
      | False => accept
      | True =>
        e = { _eventname : "Thanks" };
        event e
      end
    end

however it would be very difficult to implement analysis which catches
cases like this.

* fix bug in check_accepts which missed some code paths

Run Details

3138 of 3921 relevant lines covered (80.03%)

9689.95 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	999.1	11 Feb 2019 12:01PM UTC	0	80.03	Travis Job 999.1

Source Files on build 999

Detailed source file information is not available for this build.

Zilliqa / scilla / 999
61%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 999

Zilliqa / scilla / 999 61%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 999

Zilliqa / scilla / 999
61%

README BADGES
x