ckeditor / ckeditor5-engine / 4530

100%

push

travis-ci

Merge pull request #1644 from ckeditor/t/ckeditor5/479

Feature: Moved the root element DOM attributes management from the UI to the engine. Made it possible to use `addPlaceholder()` (now `enablePlaceholder()`) on the root editable. Introduced the `View.detachDomRoot()` method. Implemented additional placeholder helpers (`showPlaceholder()`, `hidePlaceholder()`, `needsPlaceholder()`) (see ckeditor/ckeditor5#479). Closes #899.

BREAKING CHANGE: The `attachPlaceholder()` has been renamed to `enablePlaceholder()`.
BREAKING CHANGE: `enablePlaceholder()` accepts a configuration object instead of separate parameters.
BREAKING CHANGE: The `detachPlaceholder()` has been renamed to `disablePlaceholder()`.

4802 of 4802 branches covered (100.0%)

Branch coverage included in aggregate %.

79 of 79 new or added lines in 2 files covered. (100.0%)

7852 of 7852 relevant lines covered (100.0%)

11154.93 hits per line