67
39%

Ran 06 Feb 2019 07:20AM UTC

Jobs 2

Files 9

Run time 48s

Badge

Embed ▾

pending completion

Build # 67

Build Type

push

jenkins

Committed by

Commit Message

Fix release asset upload with special characters in filename (#24)

Description
===========

The API `GHAsset uploadAsset(File file, String contentType)` in
`GHRelease` is does no `URLEncode` for the given file name. The filename
is used in the github API call as is:

```java
    String url = format("https://uploads.github.com%s/releases/%d/assets?name=%s",
                     owner.getApiTailUrl(""), getId(), filename);
```

This leads to upload errors when trying to publish files with special
characters. This patch circumvents this issue by calling the second API
`GHAsset uploadAsset(String filename, InputStream stream, String contentType)` with a URL encoded filename.

Note
----

Github renames release assets with special characters.

Changes
=======

![FIX] release asset upload with special characters in filename

Run Details

306 of 308 relevant lines covered (99.35%)

1.99 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	67.1	06 Feb 2019 07:20AM UTC	0	99.35
2	67.2	06 Feb 2019 07:21AM UTC	0	99.35

Source Files on build 67

Detailed source file information is not available for this build.

wooga / atlas-github / 67
39%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 67

wooga / atlas-github / 67 39%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 67

wooga / atlas-github / 67
39%

README BADGES
x