keathley / wallaby / 1112
85%

DEFAULT BRANCH: master
Ran
Jobs 15
Files 34
Run time 23min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1112

push

travis-ci

keathley 
Add functions for query options (#411)

Description
============

Adds functions `visible/2`, `selected/2`, `text/2`, `count/2`, and
`at/2` for query options to compose queries.

```elixir
 # Previously
query =
  Query.css(
    ".select-options",
    visible: true,
    selected: true,
    text: "Select Option 2",
    count: 1,
    at: 0
  )

 # Now we can do the following
query =
  Query.css(".select-options")
  |> Query.visible(true)
  |> Query.selected(true)
  |> Query.text("Select Option 2")
  |> Query.count(1)
  |> Query.at(0)
```

Note on `Query.text/2`
---------------------

We decided to go ahead an leave the two versions of `Query.text/2` for
now, even though they perform different actions. One version creates a
query of `method: :text` and the other adds the `text` condition to an
existing query.

Note on docs
------------

I decided _not_ to use doc tests for the examples introduced. I decided
against doc tests because the important aspect of the example was
getting lost amongst so much data. For example, one of the examples for
`text/2` was trying to show that a `Query.text("Submit", count: 1)`
would create a query struct with `method: :text`, `selector: "Submit`,
and `count: 1`. But it felt like the important information got lost
when displayed like this,

```elixir
iex> Wallaby.Query.text("Submit", count: 1)
%Wallaby.Query{method: :text, selector: "Submit", html_validation: nil,
conditions: [text: nil, visible: true, selected: :any, minimum: nil, at:
0, count: 1], result: nil}
```

802 of 875 relevant lines covered (91.66%)

179719.77 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1112.1 0
39.09
 Travis Job 1112.1
2 1112.2 0
45.14
 Travis Job 1112.2
3 1112.3 0
45.03
 Travis Job 1112.3
4 1112.4 (WALLABY_DRIVER=phantom) 0
57.14
 Travis Job 1112.4
5 1112.5 (WALLABY_DRIVER=phantom) 0
60.91
 Travis Job 1112.5
6 1112.6 (WALLABY_DRIVER=phantom) 0
60.91
 Travis Job 1112.6
7 1112.7 (WALLABY_DRIVER=chrome) 0
50.63
 Travis Job 1112.7
8 1112.8 (WALLABY_DRIVER=chrome) 0
54.97
 Travis Job 1112.8
9 1112.9 (WALLABY_DRIVER=chrome) 0
54.97
 Travis Job 1112.9
10 1112.10 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3) 0
38.06
 Travis Job 1112.10
11 1112.11 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3) 0
41.94
 Travis Job 1112.11
12 1112.12 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=3) 0
41.94
 Travis Job 1112.12
13 1112.13 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=2) 0
38.4
 Travis Job 1112.13
14 1112.14 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=2) 0
41.71
 Travis Job 1112.14
15 1112.15 (WALLABY_DRIVER=selenium WALLABY_SELENIUM_VERSION=2) 0
41.71
 Travis Job 1112.15
Source Files on build 1112
Detailed source file information is not available for this build.