spotify / folsom / 542

Ran 30 Jan 2019 01:41AM UTC

Jobs 1

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 542

Build Type

Pull #109

travis-ci

Committed by

web-flow

Commit Message

extracted yammer metrics to a separate module to limit dependencies

yammer metrics are now in a separate module because not everyone
would want to use them, and pulling in the tree of Yammer Metrics
dependencies may lead to unnecessary build complications
in consuming code.

I duplicated FakeRawMemcacheClient used in two sets of tests.
here duplication may be an acceptable solution, given the alternative
would be introducing "folsom-test" module with FakeRawMemcacheClient
class in it, which would be used from several places. but that module
would need a dependency on "folsom" module, while "folsom" module's
tests would need to access that dependency in a cycle.

a cleaner solution would be to still introduce "folsom-test" module
and move FakeRawMemcacheClient there, but then *also* move out
"ketama client", "round robin client", etc to separate modules - that
would allow avoiding dependency cycles. while that may be a good
long-term solution, I want to avoid the scope of changes in this branch,
where the goal is to remove "yammer core" dependencies tree
from the build, unless explicitly requested by the consumer.

Pull Request Pull Request #109: extracted yammer metrics to a separate module to limit dependencies

Run Details

Jobs

ID	Job ID	Ran	Files	Coverage
1	542.1	30 Jan 2019 01:41AM UTC	0		Travis Job 542.1

Source Files on build 542

Detailed source file information is not available for this build.

spotify / folsom / 542

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 542

spotify / folsom / 542

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 542

README BADGES
x