ReactiveX / rxjs / 7987

97%

push

travis-ci

fix(WebSocketSubject): fix subject failing to close socket (#4446)

Fix WebSocketSubject failing to close the underlying socket connection when it is unsubscribed
before the socket is in the open state. Currently, when unsubscribe is called on the subject or
when a subscription is unsubscribed there are checks on whether the socket is open (readyState = 1)
before it closes the connection. If unsubscribe is called before the connection is open, it will not
close the socket but will reset the state of the subject (_socket set to null), and it becomes
impossible to close the socket.

1693 of 2039 branches covered (83.03%)

7 of 7 new or added lines in 1 file covered. (100.0%)

5221 of 5399 relevant lines covered (96.7%)

1116.98 hits per line