TryGhost / Ghost-Admin / 4554

70%

push

travis-ci

🐛 Fixed drag-n-drop card reordering interfering with caption and markdown/html card text selection

closes  https://github.com/TryGhost/Ghost/issues/10399
- added a data attribute `data-koenig-dnd-disabled` which will prevent the element or any of it's children from initiating a koenig drag event
  - applied the data attribute to `{{koenig-basic-html-input}}`'s outer tag so that captions never initiate a card re-order
- disabled card re-ordering when a card is in edit mode
  - allows text selection within a markdown/html card without triggering the card re-order behaviour
  - clicking another card will exit edit mode and re-enable drag before the drag behaviour is initiated so you can still re-order other cards if you've left a card in edit mode

1852 of 2970 branches covered (62.36%)

4292 of 6015 relevant lines covered (71.35%)

46.4 hits per line