gonum / gonum / 3114

77%

push

travis-ci

lapack/gonum: fix bugs in Dgesvd and rewrite DgesvdTest

- if condition for one the paths in workspace size calculation was
  misspelled
- return value from Dbdsqr was ignored in some paths, leaving it at
  false (failed) value
- if the input matrix A was rescaled, the output singular values have
  to be unscaled back. The code uses Dlascl which treats the s slice as
  a matrix. The column major reference treats it as minmn-by-1 matrix
  with the stride minmn, and this was not correctly translated in our
  row major implementation.

Also clean up the initial parameter checks.

87 of 87 new or added lines in 2 files covered. (100.0%)

47204 of 60640 relevant lines covered (77.84%)

14.31 hits per line