jeffshantz / hyperkit / 39

99%

push

travis-ci

Let OpenSSL::PKey detect client key format automatically (#15)

Recent versions of LXD generate ECDSA keys rather than RSA keys for
client authentication, so using the `RSA` subclass of `OpenSSL::PKey` to
open them fails with the following error:

  Neither PUB key nor PRIV key: nested asn1 error (OpenSSL::PKey::RSAError)

Ruby's OpenSSL library provides a way to open any of the supported key
types, including both RSA and ECDSA, using `OpenSSL::PKey.read` [1],
which will automatically detect the format and return the subclass for
that type of key. So, in order to support both key types, we can just
use that method instead of `OpenSSL::PKey::RSA.new`.

[1]: https://ruby-doc.org/stdlib-2.6/libdoc/openssl/rdoc/OpenSSL/PKey.html#method-c-read

1 of 1 new or added line in 1 file covered. (100.0%)

2746 of 2771 relevant lines covered (99.1%)

251.88 hits per line