342
72%

Ran 27 Jan 2019 02:58PM UTC

Jobs 1

Files 494

Run time 21s

Badge

Embed ▾

pending completion

Build # 342

Build Type

push

jenkins

Committed by Sijie Guo

Commit Message

Add semantically meaningful return values to placement policy

Currently newEnsemble and replaceBookie in EnsemblePlacementPolicy
return a apache commons Pair<> with the second argument being a
boolean to denote whether the placement conforms strictly to the
policy. From calling code, the meaning of this second value is
unclear.

This patch replaces Pair<> with an PlacementResult object, in which
the strict conformity argument is clearly labels. This will also allow
extension in the future to return more metadata about particular
placements.

Also, we shouldn't put third party library classes in interfaces.

Issue:  #1914


Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Charan Reddy Guttapalem <reddycharan18@gmail.com>, Sijie Guo <sijie@apache.org>

This closes #1916 from ivankelly/meaningful-placement-res

Run Details

26367 of 36418 relevant lines covered (72.4%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	342.1	27 Jan 2019 02:58PM UTC	0	72.4

Source Files on build 342

Detailed source file information is not available for this build.

apache / bookkeeper / 342
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 342

apache / bookkeeper / 342 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 342

apache / bookkeeper / 342
72%

README BADGES
x