wikimedia / restbase / 3503

87%

master: 84%

Pull #1092

travis-ci

Fix version issue when actual patch version >= 10

Today we encountered an incident where after an MCS deploy, which
changed the summary version from 1.3.9. to 1.3.10, caused RB to rerender
the summary for every page.[1]

The problem is that the comparison previously used failed when the patch
version number was 10 or greater and the expected patch version number
is < 10.

In `node`:
> "1.3.9" > "1.3.7"
true
> "1.3.10" > "1.3.7"
false

I then considered using parseInt() but since we're using version numbers
with 2 dots that fails, too:
> parseInt("1.3.10") > parseInt("1.3.7")
false

So, I propose using the semver module which should handle that properly.
Unfortunately the current structure of this module doesn't make it easy
to create a unit test without some refactoring.

[1] https://wikitech.wikimedia.org/wiki/Incident_documentation/20190117-Parsoid

881 of 1136 branches covered (77.55%)

1 of 1 new or added line in 1 file covered. (100.0%)

1614 of 1851 relevant lines covered (87.2%)

121.78 hits per line