lukechilds / cacheable-request / 416

100%

master: 100%

push

travis-ci

Ensure request error callback runs only once (#66)

The `requestErrorCallback` can be called twice in case the request is aborted before receiving the first byte of the response, as it will emit both `abort` and `error` events. This PR ensures the logic inside `requestErrorCallback` runs only once.

There's no behavior change as calling `resolve()` after the promise is already resolved is a no-op.

This is just a sanity check to futureproof the code in case more logic is added to `requestErrorCallback` later on.

69 of 69 branches covered (100.0%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

120 of 120 relevant lines covered (100.0%)

32.03 hits per line