JuliaMath / SpecialFunctions.jl / 418

86%

master: 86%

Pull #142

travis-ci

Saving gamma: Base._fact_table64 is dangerous

If my https://github.com/JuliaLang/julia/pull/30665 will get pulled this package WILL break, I think.

https://github.com/JuliaMath/SpecialFunctions.jl/blob/9d0caf983/src/gamma.jl#L758

Base._fact_table64 is dangeraous, and as it's a "fact" table, to could alternatively be done here with:

const _fact_table64 = [cumprod(1:Int64(20))]  # as oppoed to what I changed to: const _fact_table64 = [1; cumprod(1:Int64(20))]

Such a change will not automatically benefit from my improved factorial (it seems 22%+ faster), nor would gamma fail if I screwed up...

This change would need to be merged and tagged, right, before my other PR?

Isn't this what you call type piracy ("bad")? And while I could easily have missed this, if I had not known about gamma while in Julia 0.5, is there a way of knowing (like searching globally in all Julia packages; at least those in METADATA or new registry).

1 of 1 new or added line in 1 file covered. (100.0%)

559 of 795 relevant lines covered (70.31%)

85.89 hits per line