patternfly / patternfly-react / 3884

78%

push

travis-ci

Dropdown interaction issues (#1014)

* feat(Dropdown): disable selection of disabled menu items

Select event should not fire when disabled actions in a menu are selected.

* feat(Dropdown): improved select event piping, added fix for focus trap toggle

* feat(Dropdown): assign onClick to disabled items, update tests

disabled items may be enabled by application code, so should still have the onSelect attached.

* feat(Dropdown): handle both button onclick and list onselect

Ensures that if the component is a button, the unique onClick is still fired in addition to the
onSelect

* refactor(add onClick to proptypes, pass event to functions):

n

* feat(Dropdown): use Context to pass onSelect handlers

* feat(Dropdown): remove onSelect default

update tests, rebase and resolve conflicts

* test(Dropdown): update tests from rebase

* feat(DropdownItem): add new prop to ts file

1682 of 2382 branches covered (70.61%)

Branch coverage included in aggregate %.

4371 of 5079 relevant lines covered (86.06%)

23.7 hits per line