zulip / zulip-mobile / 4089

65%

push

travis-ci

actionTypes: Fix intersections in event types.

These are nearly the last intersection types in the codebase.  Replace
them with object spreads, and also make these object types exact.

Done automatically.  First, replaced intersections with spreads by
using the codemod script introduced in the parent commit, along with
a bit of post-processing for its rather hilarious failure mode:

  jscodeshift -t tools/codemod/intersection-to-spread.js \
    src/actionTypes.js
  perl -i -0pe 's/type type/type/g' src/actionTypes.js

Then made the object types exact, the lower-tech way -- reused the
command from 9c1898242 and some earlier commits, just limiting it
to this file:

  perl -i -0pe \
    's/^((?:export )?type \S+ = \{)(\n.*?\n)?(\};)/$1|$2|$3/msg' \
    src/actionTypes.js

1399 of 2897 branches covered (48.29%)

Branch coverage included in aggregate %.

4966 of 6713 relevant lines covered (73.98%)

16.45 hits per line