openPMD / openPMD-api / 1679

87%

dev: 83%

Pull #410

travis-ci

IOTask: AbstractParameter Object Slicing

The IOTask constructor caused problems with Clang 4.0.1 on OSX,
where the `Parameter< Operation::CREATE_FILE >` does seem not to
copy the `name` member.
Thanks to Ray Donnelly for first seeing this!

~~It turns out that we copy the `AbstractParameter` base class,
which leads to object slicing.~~
Probably implicit copy constructors are weirdly handled in this
old Clang version, so we make them explicitly deleted as the
core guidelines recommend.

Also, `IOTasks` might better have an explicit copy constructor
since we copy it around (`std::queue::push()`, etc.)

https://stackoverflow.com/questions/274626/what-is-object-slicing
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-copy-virtual
https://en.wikipedia.org/wiki/Object_slicing

99 of 99 new or added lines in 1 file covered. (100.0%)

5197 of 5983 relevant lines covered (86.86%)

0.87 hits per line