pydata / xarray / 6493

96%

push

travis-ci

<a href="https://github.com/pydata/xarray/commit/<a class=hub.com/pydata/xarray/commit/<a class="double-link" href="https://git"><a class=hub.com/pydata/xarray/commit/6963164dbdc55f86f34b741073838f083a68a152">6963164db<a href="https://github.com/pydata/xarray/commit/6963164dbdc55f86f34b741073838f083a68a152">&lt;a href=&quot;https://github.com/pydata/xarray/commit/6963164dbdc55f86f34b741073838f083a68a152&quot;&gt;&amp;quot;&amp;gt;Type checking with mypy (#2655)

* Type checking with mypy

The rest of the scientific Python stack doesn&amp;amp;#39;t seem to support type
annotations yet, but that&amp;amp;#39;s OK -- we can use this incrementally in xarray when
it seems appropriate, and may check a few bugs. I&amp;amp;#39;m especially excited to use
this for internal functions, where we don&amp;amp;#39;t always bother with full docstrings
(e.g., what is the type of the ``variables`` argument?).

This includes:
1. various minor fixes to ensure that &amp;amp;quot;mypy xarray&amp;amp;quot; passes.
2. adding &amp;amp;quot;mypy xarray&amp;amp;quot; to our lint check on Travis-CI.

For reference, see &amp;amp;quot;Using mypy with an existing codebase&amp;amp;quot;:
https://mypy.readthedocs.io/en/stable/existing_code.html

Question: are we OK with (2)? This means Travis-CI will fail if your code
causes mypy to error.

* Lint fix

* DOC: document mypy, don&amp;amp;#39;t run it in travis

* document how to run mypy

* fix type annotation

* Pin pytest to avoid pytest-cov failure

see https://github.com/pytest-dev/pytest-cov/pull/253

* Revert pytest pinning

* Revert &amp;quot;Revert pytest pinning&amp;quot;

This reverts commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/pydata/xarray/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/pydata/xarray/commit/cd187a64eb97ca917476046a2f33c2a995a18680&quot;>cd187a64e</a>">cd187a64e</a><a href="https://github.com/pydata/xarray/commit/6963164dbdc55f86f34b741073838f083a68a152">.

* Revert &quot;Pin pytest to avoid pytest-cov failure&quot;

This reverts commit </a><a class="double-link" href="https://github.com/pydata/xarray/commit/<a class="double-link" href="https://github.com/pydata/xarray/commit/87ba452fad10f9f3715edae12abb1f28153ce99c">87ba452fa">87ba452fa.

69 of 69 new or added lines in 21 files covered. (100.0%)

27459 of 28435 relevant lines covered (96.57%)

7.18 hits per line