dunst-project / dunst / 1093

48%

master: 49%

Pull #585

travis-ci

Manually convert GdkPixbuf to cairo surfaces

As already noted in the code comment, we all knew that the in memory
conversion to a PNG stream is a cumbersome technique. But it was worth
to remove the GTK dependency.

After finding out, that gdk_pixbuf_new_from_data can actually use a
GVariant and share its memory without allocating new memory, I poked
the cairo docs for a similar technique.

There is cairo_image_surface_create_for_data, which would achieve the
same, but cairo uses another color byte order. So we have to manually
copy and reassemble the bytes.

It may look like a big rise in complexity, but actually, it's straight
forward copying pixel by pixel and changing the byte's order.

And the gdk_pixbuf_to_cairo_surface is 33x faster.

37 of 37 new or added lines in 1 file covered. (100.0%)

1463 of 3072 relevant lines covered (47.62%)

53.46 hits per line