zulip / zulip-mobile / 7969

65%

push

travis-ci

android: Actually declare VIBRATE permission.

The wix notification library's manifest file has this element with
`android:maxSdkVersion="18"`, so it only applies on API <= 18 (which
we don't even support).  That appears to be intended as a workaround
for an ancient Android bug, fixed in Android 4.2.1 and 4.3 here (and
yes, the "DO NOT MERGE" is in the original, lol):

  https://android.googlesource.com/platform/frameworks/base/+/cc2e849fa

  Notification vibration improvements: [DO NOT MERGE]

   - When notifications vibrate as a fallback (that is,
     because they want to play a sound but the device is in
     vibrate mode), this no longer requires the VIBRATE
     permission.
   - As a bonus, if your notifications use DEFAULT_VIBRATE,
     you don't need the VIBRATE permission either.
   - If you specify a custom vibration pattern, you'll still
     need the VIBRATE permission for that.
   - Notifications vibrating in fallback mode use same
     vibration pattern but can be changed easily in future.
   - The DEFAULT_VIBRATE and fallback vibrate patterns are now
     specified in config.xml.

(That commit appears in `git log android-4.2_r1..android-4.2.1_r1`,
and is present in `android-4.3_r1` too.  Android 4.2 is API 17, and
Android 4.3 is API 18.)

OK, but we *do* (attempt to -- see below) specify a custom vibration
pattern.  So we need the VIBRATE permission even after this bug fix.

And we've had this element in our manifest to do that... but when the
Android build system merges our manifest with the library's, that
extra `android:maxSdkVersion` attribute from the library gets merged
into this element, so the much narrower workaround-request in the
library effectively clobbers our broader request.

As a result, our custom vibration pattern couldn't ever have worked,
except for the few users on API <=18 back when we even supported that.
Fix the manifest so that any non-default vibration settings can
possibly work at all.

---

Even after this fi... (continued)

1399 of 2897 branches covered (48.29%)

Branch coverage included in aggregate %.

4965 of 6701 relevant lines covered (74.09%)

16.48 hits per line