394
75%
5.2: 70%

Ran 30 Dec 2018 02:51PM UTC

Jobs 1

Files 13

Run time 1s

Badge

Embed ▾

pending completion

Build # 394

Build Type

push

travis-ci

Committed by

crynobone

Commit Message

[PATCH] Simplify `hasFormMutator` method

The previous implementation that relied on Reflection is causing fatal
PHP errors, when a Model which uses the FormAccessible trait is being
dumped (with Symfony's dumper).

The reason is because the dumper is using reflection to dump all the
model's properties, and when it hits the `reflection` property, it tries
to cast the `ReflectionClass` using `ReflectionClass`, which causes an
`Internal error: Failed to retrieve the reflection object`.

The new implementation uses the same stragegy as Eloquent's
`hasGetMutator`, which calls `method_exists`.

This is more efficient as we don't need a whole reflection object,
neither we need to iterate through all the reflected public properties
of the model, just to find the first one that matches the mutator method
name.

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>

Run Details

339 of 454 relevant lines covered (74.67%)

7.13 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
13	394.13 (setup=coveralls coverage=yes)	30 Dec 2018 02:50PM UTC	0	74.67	Travis Job 394.13

Source Files on build 394

Detailed source file information is not available for this build.

laravie / html / 394
75%
5.2: 70%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 394

laravie / html / 394 75% 5.2: 70%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 394

laravie / html / 394
75%
5.2: 70%

README BADGES
x