• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

zulip / zulip-mobile / 7888
65%

Build:
DEFAULT BRANCH: master
Ran 28 Dec 2018 03:23AM UTC
Jobs 1
Files 361
Run time 23s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
7888

push

travis-ci

gnprice
ZulipStatusBar: Fix types in `connect` call.

Some changes I was experimenting with somehow inspired Flow
to start pointing out things like

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/common/ZulipStatusBar.js:71:20

Property backgroundColor is missing in props [1].

     src/common/ZulipStatusBar.js
     68│ export default connect((state, props) => ({
     69│   safeAreaInsets: getSession(state).safeAreaInsets,
     70│   theme: getSettings(state).theme,
     71│   backgroundColor: props.backgroundColor || getTitleBackgroundColor(props.narrow)(state),
     72│   orientation: getSession(state).orientation,
     73│ }))(ZulipStatusBar);
     74│

     src/chat/ChatScreen.js
 [1] 36│           <ZulipStatusBar narrow={narrow} />

Where indeed, that code uses `props.backgroundColor` in a way that
looks like it assumes such a prop is present.  It doesn't really, but
that's hard to tell without more context.

Make the logic more explicit, which fixed those errors.  As a bonus,
the two remaining "ST is not a React component" errors go away too!

1402 of 2916 branches covered (48.08%)

Branch coverage included in aggregate %.

4931 of 6683 relevant lines covered (73.78%)

50.15 hits per line

Jobs
ID Job ID Ran Files Coverage
1 7888.1 (COVERALLS_REPO_TOKEN=4eYQDtWoBJlDz2QkxoQ2UcnmJFcOB7zkv) 28 Dec 2018 03:23AM UTC 0
65.98
Travis Job 7888.1
Source Files on build 7888
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #7888
  • 5c39d0fc on github
  • Prev Build on master (#7887)
  • Next Build on master (#7889)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc