zulip / zulip-mobile / 7888

65%

push

travis-ci

ZulipStatusBar: Fix types in `connect` call.

Some changes I was experimenting with somehow inspired Flow
to start pointing out things like

Error ┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈┈ src/common/ZulipStatusBar.js:71:20

Property backgroundColor is missing in props [1].

     src/common/ZulipStatusBar.js
     68│ export default connect((state, props) => ({
     69│   safeAreaInsets: getSession(state).safeAreaInsets,
     70│   theme: getSettings(state).theme,
     71│   backgroundColor: props.backgroundColor || getTitleBackgroundColor(props.narrow)(state),
     72│   orientation: getSession(state).orientation,
     73│ }))(ZulipStatusBar);
     74│

     src/chat/ChatScreen.js
 [1] 36│           <ZulipStatusBar narrow={narrow} />

Where indeed, that code uses `props.backgroundColor` in a way that
looks like it assumes such a prop is present.  It doesn't really, but
that's hard to tell without more context.

Make the logic more explicit, which fixed those errors.  As a bonus,
the two remaining "ST is not a React component" errors go away too!

1402 of 2916 branches covered (48.08%)

Branch coverage included in aggregate %.

4931 of 6683 relevant lines covered (73.78%)

50.15 hits per line