pydata / xarray / 6352

96%

push

travis-ci

Close files when CachingFileManager is garbage collected (#2595)

* Close files when CachingFileManager is garbage collected

Fixes GH2560

This frees users from needing to worry about this.

* Minor tweak

* Test raising an error in __del__

* restore change

* Remove the need for a lock in __del__

* Handle locking ourselves with rasterio

* Remove race condition with netCDF4

* refactor optional lock

* Fix more possible race conditions

* Warn if we can't close in FileManager.__del__

* Fix lock acquisition in CachingFileManager.__del__

* Cleaner fall-back for no dask-distributed

* Test tweaks

* Test for FileManager.__repr__

* Add reference counting to CachingFileManager

* remove unused import

* Spelling / reorg

219 of 219 new or added lines in 12 files covered. (100.0%)

27202 of 28127 relevant lines covered (96.71%)

8.11 hits per line