wikimedia / restbase / 912

84%

Pull #213

travis-ci

Store content using the canonical title only

Requests with a non-canonical title (example: 'foobar' vs. 'Foobar') can
currently cause key_rev_value content to be stored using both the
non-canonical version ('foobar') and the canonical version ('Foobar'). This is
bad for performance and consistency.

This patch avoids this by comparing the normalized title retrieved from
page_revisions with the (slightly pre-normalized) request title. If the two
differ, the request is retried against storage before (potentially) creating
the content.

Also:

- clean up / simplify getRevisionInfo a bit.
- only set the tid in getBucketURI if the revision is also defined

23 of 23 new or added lines in 2 files covered. (100.0%)

772 of 875 relevant lines covered (88.23%)

72.29 hits per line