openconfig / ygot / 1403

89%

push

travis-ci

Fix error formatting in Validate. (#261)

* Fix error formatting in Validate.

 * (M) util/errs*
  - Add functions to deduplicate util.Errors and prefix all errors in a
    supplied util.Errors.
 * (M) ytypes/{validate,container}*
  - Ensure that when an error is returned by Validate() each path
    element is not a separate error in the slice -- there was some
    re-use of the errors slice that caused this to be the case. This
    matters only to consumers that parse ytypes' return value as a
    util.Errors, string users were unaffected.
  - Ensure that where duplicate errors occur (same regexp, same schema
    path) only one error is returned. In the future, we should track the
    datatree path, but this is currently not possible without more major
    refactoring of Validate().
 * (M) ytypes/schema_tests/validate_test.go
  - Add test cases checking error output.

* Fix test flake.

18 of 18 new or added lines in 2 files covered. (100.0%)

8974 of 9836 relevant lines covered (91.24%)

1807.71 hits per line