437
24%

Ran 06 Mar 2015 07:03PM UTC

Jobs 11

Files 20

Run time 14min

Badge

Embed ▾

pending completion

Build # 437

Build Type

Pull #158

travis-ci

Committed by

gnat42

Commit Message

Don't inject the complete DIC

I'm fairly certain its bad practice to inject the entire DIC into a service
unless you have issues with circular dependencies or other issues. Therefore
the CKEditorHelper has been refactored to have the router and template asset
helper injected directly.

Pull Request Pull Request #158: Don't inject the complete DIC

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

592 of 608 relevant lines covered (97.37%)

158.24 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
16	58.97	-41.03%	Twig/CKEditorExtension.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	437.1	06 Mar 2015 07:03PM UTC	20	100.0	Travis Job 437.1
2	437.2	06 Mar 2015 07:03PM UTC	20	100.0	Travis Job 437.2
3	437.3	06 Mar 2015 07:03PM UTC	20	100.0	Travis Job 437.3
4	437.4	06 Mar 2015 07:03PM UTC	20	100.0	Travis Job 437.4
5	437.5	06 Mar 2015 07:03PM UTC	20	100.0	Travis Job 437.5
6	437.6	06 Mar 2015 07:10PM UTC	20	67.11	Travis Job 437.6
9	*437.9 (SYMFONY_VERSION=2.2.)**	06 Mar 2015 07:10PM UTC	20	100.0	Travis Job 437.9
10	*437.10 (SYMFONY_VERSION=2.4.)**	06 Mar 2015 07:10PM UTC	20	100.0	Travis Job 437.10
11	*437.11 (SYMFONY_VERSION=2.5.)**	06 Mar 2015 07:15PM UTC	20	100.0	Travis Job 437.11
12	*437.12 (SYMFONY_VERSION=2.6.)**	06 Mar 2015 07:18PM UTC	20	100.0	Travis Job 437.12
13	*437.13 (SYMFONY_VERSION=2.7.@dev)**	06 Mar 2015 07:16PM UTC	20	67.68	Travis Job 437.13

Source Files on build 437

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

egeloen / IvoryCKEditorBundle / 437
24%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 437

egeloen / IvoryCKEditorBundle / 437 24%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 437

egeloen / IvoryCKEditorBundle / 437
24%

README BADGES
x