607
81%

Ran 12 Dec 2018 06:54PM UTC

Jobs 1

Files 99

Run time 12s

Badge

Embed ▾

pending completion

Build # 607

Build Type

push

travis-ci

Committed by

azat

Commit Message

http: fix connection retries when there more then one request for connection

We should not attemp to establishe the connection if there is retry
timer active, since otherwise there will be a bug.

Imagine next situation:
  con = evhttp_connection_base_new()
  evhttp_connection_set_retries(con, 2)
  req = evhttp_request_new()
  evhttp_make_request(con, req, ...)
  # failed during connecting, and timer for 2 second scheduler (retry_ev)

Then another request scheduled for this evcon:
  evhttp_make_request(con, req, ...)
  # got request from server,
  # and now it tries to read the response from the server
  # (req.kind == EVHTTP_RESPONSE)
  #
  # but at this point retry_ev scheduled,
  # and it schedules the connect again,
  # and after the connect will succeeed, it will pick request with
  # EVHTTP_RESPONSE for sending and this is completelly wrong and will
  # fail in evhttp_make_header_response() since there is no
  # "http_server" for this evcon

This was a long standing issue, that I came across few years ago
firstly, bad only now I had time to dig into it (but right now it was
pretty simple, by limiting amount of CPU for the process and using rr
for debug to go back and forth).

Run Details

11006 of 13670 relevant lines covered (80.51%)

248875.45 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	607.1 (EVENT_BUILD_METHOD=cmake EVENT_CMAKE_OPTIONS="-DEVENT__COVERAGE=ON -DCMAKE_BUILD_TYPE=debug" COVERALLS=yes)	12 Dec 2018 06:54PM UTC	0	80.51	Travis Job 607.1

Source Files on build 607

Detailed source file information is not available for this build.

libevent / libevent / 607
81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 607

libevent / libevent / 607 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 607

libevent / libevent / 607
81%

README BADGES
x