CKI-project / skt / 1523

78%

push

travis-ci

silence/fix "Could not cancel job" bug

We get error like

"""
XML-RPC fault: <class 'bkr.common.bexceptions.BX'>:Could not cancel job
id 5105713. Please try later
"""

when jobs are cancelled. This is because Beaker cancels entire jobs when
asked to cancel any of recipsets of that job and afterwards we try to
cancel a job already cancelled.

This patch adjusts cancel_pending_jobs() and its test.
We cancel entire jobs, if they have any recipeset in watchlist.
(Watchlist contains only recipsets.) This way the code shouldn't try to
cancel anything else than watchlist.

V2:
* better sets2jobs filtering

Signed-off-by: Jakub Racek <jracek@redhat.com>

359 of 448 branches covered (80.13%)

Branch coverage included in aggregate %.

1121 of 1341 relevant lines covered (83.59%)

0.84 hits per line