5069
68%
master: 97%

Ran 06 Mar 2015 01:49PM UTC

Jobs 1

Files 69

Run time 5s

Badge

Embed ▾

pending completion

Build # 5069

Build Type

push

travis-ci

Committed by

nickstenning

Commit Message

Fix share dialog

Previously, the event from the initial click on the "share" event was
swallowed by the click handler on the parent thread:

    https://github.com/hypothesis/h/blob/fef9f43/h/static/scripts/directives/thread.coffee#L198-L221

Removing this has meant that the share dialog never shows.

Incidentally, this also fixes #1802, which was caused by the same code
in the thread directive, which swallowed all click events from its
children and hence prevented the closure of the share dialog.

Run Details

2546 of 3724 relevant lines covered (68.37%)

0.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5069.1	06 Mar 2015 01:49PM UTC	0	68.37	Travis Job 5069.1

Source Files on build 5069

Detailed source file information is not available for this build.

hypothesis / h / 5069
68%
master: 97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5069

hypothesis / h / 5069 68% master: 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5069

hypothesis / h / 5069
68%
master: 97%

README BADGES
x